Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

feat!: use blake3 for hashing #358

Open
wants to merge 6 commits into
base: v0.22-dev
Choose a base branch
from
Open

feat!: use blake3 for hashing #358

wants to merge 6 commits into from
+139 −99

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Oct 20, 2021

Issue being fixed or feature implemented

Updating hash function to use blake3

What was done?

  • updated hash module to support 2 hashes blake3 and double-sha256
  • use blake3 for hash methods

How Has This Been Tested?

  • unit and integration tests

Breaking Changes

  • hash function is not compatible with old one

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.22.0 milestone Oct 20, 2021
@jawid-h jawid-h requested review from shumkov and antouhou October 20, 2021 14:50
shumkov
shumkov reviewed Nov 1, 2021
View reviewed changes
lib/util/hash.js
@@ -1,16 +1,25 @@
const crypto = require('crypto');
const blake3Promise = require('blake3/dist/node');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work in karma?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov left review comments

@antouhou antouhou Awaiting requested review from antouhou

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jawid-h @shumkov